allow webapp service account id to be customised and SQL instance to be blank

As noted in #6 (closed), we were hard-coding the service account id used for the webapp to "webapp-run". This meant it was impossible to deploy more than one webapp in a project.

As noted in #5 (closed), sometimes we didn't want to associate a SQL instance with the webapp.

Form a better default from the "name" variable. For existing deployments the service account id will be unchanged if the "name" variable is at its default value.

Allow the service account id to be specified explicitly via the optional "service_account_id" variable.

Allow sql_instance_connection_name to be blank. If so, we don't set the Cloud SQL annotation on the service or attempt to grant the service account roles.

Closes #6 (closed) Closes #5 (closed)

changed milestone to %Sprint 98

added 1 commit

• e1013a88 - allow webapp service account id to be customised

Compare with previous version

added 1 commit

• 644f2ab4 - allow webapp service account id to be customised

Compare with previous version

added 1 commit

• b2f9a42a - Allow sql_instance_connection_name to be empty

Compare with previous version

changed title from allow webapp service account id to be customised to allow webapp service account id to be customised and SQL instance to be blank

changed the description

added 5 commits

• b2f9a42a...769a0528 - 3 commits from branch master
• 27dd7ccd - allow webapp service account id to be customised
• 0753dceb - Allow sql_instance_connection_name to be empty

Compare with previous version

Use of these new features can be seen in https://gitlab.developers.cam.ac.uk/uis/devops/uga/deploy/-/merge_requests/19.

assigned to @amc203

resolved all threads

approved this merge request

resolved all threads

added 1 commit

• 61a5460e - Apply suggestion to main.tf

Compare with previous version

approved this merge request

mentioned in commit 38156df5

merged