Use Google Beta provider to allow for min-scale option

Tested under: https://gitlab.developers.cam.ac.uk/uis/devops/iam/deploy-identity/-/merge_requests/19

assigned to @wgd23

Tested under https://gitlab.developers.cam.ac.uk/uis/devops/iam/deploy-identity/-/merge_requests/19

this is already enabled in line 43 with a variable, I'd just add a variable there that if there is a min-scale that gets enabled as well.

Ha! completely missed that.

changed this line in version 2 of the diff

requested review from @amc203

added 1 commit

• 8aac5e6f - Only enable launch-stage beta conditionally

Compare with previous version

added 1 commit

• ac6ccb6f - Only enable launch-stage beta conditionally

Compare with previous version

Maybe we could move this to a local, say local.enable_beta_launch_stage set in locals.tf? Then it becomes clearer that this expression is to determine which launch stage to use and, when used here, is clearer why we're enabling the beta launch stage.

And, while we're at it, have a variable, var.enable_beta_launch_stage which can be used to force beta if there is some external reason for doing so.

So:

# locals.tf

locals {
  # ...

  # Logic determining if we need to enable the beta launch stage for the service
  enable_beta_launch_stage = var.enable_beta_launch_stage || var.allowed_ingress != "all" || var.min_scale > 0
}

# variables.tf

variable "enable_beta_launch_stage" {
  default     = false
  description = "Force use of the 'BETA' launch stage for the service."
}

changed this line in version 4 of the diff

Sounds good to me - implemented.

Looks good to me. Testing with the MR which motivated the change now.

Tested myself and confirmed that min_scale works correctly using https://gitlab.developers.cam.ac.uk/uis/devops/iam/deploy-identity/-/merge_requests/19

min_scale = 1:

min_scale = 0:

added 1 commit

• 60946f5c - Refactor enabling beta launch stage to local with variable override

Compare with previous version

requested review from @rjw57

approved this merge request

unapproved this merge request

approved this merge request

merged

mentioned in commit 993db4d1

Updating v1 branch