Site monitoring function fails to deploy without `local_files_dir`

Description

This module makes use of the gcp-site-monitoring module which in turns make use of gcp-function. gcp-function has a known issue when the local_files_dir is not set, the CI apply job fails. See here for more information.

At the moment, the gcp-cloud-run-app module does not expose nor pass the local_files_dir variable value to the site monitoring module. As a result, users cannot apply changes using CI when the authentication_proxy is enabled.

The "correct" solution to this is unclear see here.

Acceptance criteria

• local_files_dir is passed through to the gcp-site-monitoring module call to workaround this issue.

Links/references

https://gitlab.developers.cam.ac.uk/uis/devops/digital-admissions/admissions-portal/ap-deployment/-/issues/242#note_748786

added issuetypeTask teamDevOps workflowNeeds Refinement labels

changed title from local_files_{-d-}ir is not set to Site monitoring function fails to deploy without local_files_{+f+}ir

This should possibly is converted to a bug issue.

changed title from Site monitoring function fails to deploy without local_files_{-f-}ir to Site monitoring function fails to deploy without local_files_{+d+}ir

changed the description

added priority1 High teamCloud labels and removed teamDevOps label

I've assigned this to teamCloud so that it shows up in our next refinement for discussion on the best way to solve this. For the time being it seems that the "best" workaround is to apply the changes via executing logan locally if you hit this issue.

mentioned in issue gcp-site-monitoring#21 (closed)

Discussion in refinement:

• This only effects piipeline deployments
• local_files_dir needs to be passed to the gcp-site-monitoring module
• See gcp-site-monitoring#21 (closed)

added workflowBacklog label and removed workflowNeeds Refinement label

changed iteration to Cloud Team Sprints Jan 1, 2025 - Jan 14, 2025

assigned to @rk725

added workflowIn Progress label and removed workflowBacklog label

mentioned in merge request !83 (merged)

added workflowReview Required label and removed workflowIn Progress label

changed the description

mentioned in commit f836c0a0

closed with merge request !83 (merged)

added workflowDone label and removed workflowReview Required label