As referencing Secret Manager secrets has moved to GA. See:
https://cloud.google.com/run/docs/release-notes#November_09_2021

Arun Patel authored 3 years ago and Wajdi Hajji committed 3 years ago

This works with Terraform v0.14.10; the data source is read before
the plan walk, so the existing deployed image can be determined.
However, it is suggested that future Terraform may combine the
refresh and plan walks which *may* result in a cyclic dependancy.

Arun Patel authored 3 years ago and Wajdi Hajji committed 3 years ago

This works with Terraform v0.14.10; the data source is read before
the plan walk, so the existing deployed image can be determined.
However, it is suggested that future Terraform may combine the
refresh and plan walks which *may* result in a cyclic dependancy.

This works with Terraform v0.14.10; the data source is read before
the plan walk, so the existing deployed image can be determined.
However, it is suggested that future Terraform may combine the
refresh and plan walks which *may* result in a cyclic dependancy.

There are a few more attributes which Google has started using
internally to record state. Add them to the ignore changes list so that
terraform won't keep wanting to change resources.

Part of uis/devops/raven/infrastructure#32

Rather than ship our own monitoring module, make use of the
gcp-site-monitoring module. This effectively makes this module require
0.13 so a major version bump is required.

Closes #13

It would appear that the "run.googleapis.com/ingress" annotation can be
set to "all" without having to enable the beta launch stage. Indeed it
*has* to be set to "all" since attempting to unset it causes Cloud Run
to immediately reset it.

The "run.googleapis.com/ingress-status" annotation is maintained by the
infrastructure Google-side so ignore changes to it.

Provide a variable which allows ingress type to be specified. This
allows placing the service behind Cloud Load Balancer.

Provide variables which allow extra annotations to be added to the Cloud
Run service and the service template.

As noted in #11, we do not support the common case where a single
Stackdriver workspace hosts multiple projects. Do this by requiring a
Google provider for the Stackdriver workspace be passed to the module is
alerting is enabled.

We use a separate provider because the provider used must be able to
create monitoring resources *in the host project*. In the case of our
standard deployment, this implies it needs *product admin* credentials.

We no longer need to enable the monitoring service since this service a)
needs to be enabled in the *host* project and b) the service will have
been enabled as a necessary side-effect of creating the Stackdriver
workspace.

Closes #11

Also remove the alerting_enabled default to false for two reasons:
1) To force the developer to make a decision on monitoring
2) If alerting_enabled is true but alerting_email_address is not set up, then there is not much point as we don't have any other channel set up.

Sometimes we don't need a SQL instance for the webapp. Allow
sql_instance_connection_name to be empty and, if so, don't add the Cloud
SQL connection roles to the service account or add the SQL instance
annotation to the webapp.

Closes #5

As noted in #6, we were hard-coding the service account id used for the
webapp to "webapp-run". This meant it was impossible to deploy more than
one webapp in a project.

Form a better default from the "name" variable. For existing deployments
the service account id will be unchanged if the "name" variable is at
its default value.

Allow the service account id to be specified explicitly via the
optional "service_account_id" variable.

Closes #6

We no longer need the random id hack for generating Cloud Run resource
names as the provider now supports a autogenerate_revision_name flag
which allows Google to generate the appropriate resource name for us.

Closes #4

Ignoring changes in name means that one can never run terraform
deployments beyond the initial creation of the webapp service. Terraform
will always modify a service in-place but try to use the same name which
negates the point of *setting* the name in the
google_cloud_run_service.webapp resource.

The downside of this is that one can't then deploy changes without
deleting and re-creating random_id.webapp_revision_name resource but
that is at least documented in the README.