FAQ | This is a LIVE service | Changelog

Skip to content
Snippets Groups Projects

Allow empty responses at the end of retrieving pages of objects from Google API

Merged Robin Goodall requested to merge fix-group-paging into master

Changes logic of recognising failure of getting response from Google API.

Not ideal as Google API shouldn't ever be returning an empty response. It would ideally return a empty set of results and no next page). But prevents the sync getting blocked when we have exactly a factor of 200 groups in GWorkspace.

Closes: #38 (closed)

Merge request reports

Pipeline #234429 passed with warnings

Pipeline passed with warnings for 2fb02183 on fix-group-paging

Test coverage 36.00% (0.00%) from 1 job

Merged by Robin GoodallRobin Goodall 2 years ago (Oct 3, 2022 10:08am UTC)

Loading

Pipeline #236064 passed with warnings

Pipeline passed with warnings for ad5fd3b8 on master

Test coverage 36.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading