Failure to get group list when page size exactly matches results

See pipeline: https://gitlab.developers.cam.ac.uk/uis/devops/gsuite/sync-deploy/-/jobs/676579

Exactly 6200 groups but it appears nextTokenPage in the final result is not NULL (perhaps it is an empty string).

added issuetypeBug placeholder priority0 Highest teamIdentity urgent workflowSprint Ready labels

changed iteration to IAM Sprint Sep 14, 2022 - Sep 27, 2022

changed iteration to IAM Sprint Aug 31, 2022 - Sep 13, 2022

removed urgent label

perhaps it is an empty string

Nope appears to be a cursor string like the rest.

assigned to @rjg21

added workflowIn Progress label and removed workflowSprint Ready label

There's already some 'hacks' to cope with API giving an empty response (at beginning of getting the list) but much harder to know if this was a failed response or one of these cases. Really the API should be returning a { groups: [], nextPageToken: null } for this empty page not just {}

Believe we now have 6201 groups so the pipeline should at least succeed next run, even if this issue hasn't been resolved.

Trying to avoid hideous hack that goes, "we failed with an empty response multiple times, yet we had already do some groups, so try again with a different page size and see if we get them correctly this time"...

Spoke to soon, of course there are more than 6200 group in Lookup but until the sync can get all 6200 from Google it won't create the new ones... I'll fiddle the number in Google to get this sync to catch up.

Deleting a group from Google to it only had 6199 fixed the immediate issue, not the problem

removed iteration IAM Sprint Aug 31, 2022 - Sep 13, 2022

changed iteration to IAM Sprint Sep 14, 2022 - Sep 27, 2022

mentioned in merge request !28 (merged)

added workflowReview Required label and removed workflowIn Progress label

removed iteration IAM Sprint Sep 14, 2022 - Sep 27, 2022

changed iteration to IAM Sprint Sep 28, 2022 - Oct 11, 2022

mentioned in commit ad5fd3b8

closed with merge request !28 (merged)