FAQ | This is a LIVE service | Changelog

Skip to content
Snippets Groups Projects

"Fixes" needed for Michaelmas 2022 sync

Merged Robin Goodall requested to merge allow-filter-rooms-by-building into master

Needed to run two syncs with different subset of rooms, so added functionality to allow filter of rooms by their building, both only those in the specified building(s) and all excluding those in the specified building(s) with booker.only_buildings and booker.exclude_buildings state keys.

Discovered Booker calendar event (bookings) API endpoint returning 500, possibly due to number of events in response. Hacked the bookings retrieve code to get events one room at a time instead of all at once. Appears to fix. This is seen in scheduled test pipeline failing for Booker staging: https://gitlab.developers.cam.ac.uk/uis/devops/essm/sync-tool/-/jobs/643560

Had to fiddle how tests mock event/bookings responses, avoiding having to recreate a load of additional fixtures.

Fallout from: administration#51

Merge request reports

Pipeline #218263 passed

Pipeline passed for ec91ca1c on allow-filter-rooms-by-building

Test coverage 96.00% (0.00%) from 1 job

Merged by Robin GoodallRobin Goodall 2 years ago (Aug 22, 2022 10:25am UTC)

Loading

Pipeline #223431 passed

Pipeline passed for 8b27dea2 on master

Test coverage 96.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading