FAQ | This is a LIVE service | Changelog

Skip to content
Snippets Groups Projects
Commit c4d33fbd authored by James Barr's avatar James Barr
Browse files

docs: include disble monitoring in cloudrun changes

parent b57d42d0
No related branches found
No related tags found
1 merge request!455Cloudrun v9 migration guide updates
......@@ -97,13 +97,15 @@ https://gitlab.developers.cam.ac.uk/uis/devops/infra/terraform/gcp-cloud-run-app
```
- `sql_instance_connection_name`: has been changed to `mount_cloudsql_instance`.
- `disable_monitoring`: has been renamed to `enable_monitoring` and the new default behaviour is to
disable monitoring.
- `environment_variables`: now this variable is not declared at the top level. Instead, each
container in `containers` map has an `env` key with a list of maps (see example above).
- `allowed_ingress`: changed to `ingress`. The ingress setting for the Cloud Run service.
Possible values are `INGRESS_TRAFFIC_ALL`, `INGRESS_TRAFFIC_INTERNAL_ONLY`, and
`INGRESS_TRAFFIC_INTERNAL_LOAD_BALANCER`. If variable `use_load_balancer` is set to `true`,
the provided `ingress` value will be ignored and the ingress will be set automatically to
`INGRESS_TRAFFIC_INTERNAL_LOAD_BALANCER``.
`INGRESS_TRAFFIC_INTERNAL_LOAD_BALANCER`.
- `alert_notification_channels`: has been changed to `alerting_notification_channels`.
### Deleted features
......
......@@ -135,12 +135,22 @@ In the example code mentioned above we need to update the following options:
}
```
- `sql_instance_connection_name`: this variable in now renamed to `mount_cloudsql_instance`:
- `sql_instance_connection_name`: has been renamed to `mount_cloudsql_instance`:
```tf
mount_cloudsql_instance = module.sql_instance.instance_connection_name
```
- `disable_monitoring`: has been renamed to `enable_monitoring` and the new default behaviour is to
disable monitoring.
```tf
enable_monitoring = true
```
For a full list of the changes to input variables refer to the [explanation
page](../explanations/gcp-cloud-run-app-module.md).
### Adapt other changes
If the project has the load balancer configured, use the `moved` blocks as shown in the
......@@ -200,3 +210,4 @@ as the Cloud Run apps will be recreated (as well as a subset of auxiliary terraf
## Useful links
- [More examples in the module's GitLab project](https://gitlab.developers.cam.ac.uk/uis/devops/infra/terraform/gcp-cloud-run-app/-/blob/master/docs/examples.md)
- [Migrating to Google Cloud Run App Terraform module v9.0.0](../explanations/gcp-cloud-run-app-module.md)
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment