diff --git a/docs/explanations/gcp-cloud-run-app-module.md b/docs/explanations/gcp-cloud-run-app-module.md index 20c9c768b60da1d69ef0bfcf27736bb18451b8f1..254b572be49b52c934447ec4264ec334b6e7acde 100644 --- a/docs/explanations/gcp-cloud-run-app-module.md +++ b/docs/explanations/gcp-cloud-run-app-module.md @@ -97,13 +97,15 @@ https://gitlab.developers.cam.ac.uk/uis/devops/infra/terraform/gcp-cloud-run-app ``` - `sql_instance_connection_name`: has been changed to `mount_cloudsql_instance`. +- `disable_monitoring`: has been renamed to `enable_monitoring` and the new default behaviour is to + disable monitoring. - `environment_variables`: now this variable is not declared at the top level. Instead, each container in `containers` map has an `env` key with a list of maps (see example above). - `allowed_ingress`: changed to `ingress`. The ingress setting for the Cloud Run service. Possible values are `INGRESS_TRAFFIC_ALL`, `INGRESS_TRAFFIC_INTERNAL_ONLY`, and `INGRESS_TRAFFIC_INTERNAL_LOAD_BALANCER`. If variable `use_load_balancer` is set to `true`, the provided `ingress` value will be ignored and the ingress will be set automatically to - `INGRESS_TRAFFIC_INTERNAL_LOAD_BALANCER``. + `INGRESS_TRAFFIC_INTERNAL_LOAD_BALANCER`. - `alert_notification_channels`: has been changed to `alerting_notification_channels`. ### Deleted features diff --git a/docs/howtos/migrate-a-gcp-cloud-run-app-terraform-deployment-to-v9.md b/docs/howtos/migrate-a-gcp-cloud-run-app-terraform-deployment-to-v9.md index 9cb210c1db66ea8c9a1487d55abcfbe1747551ab..b156cfd6194a759d46721b2977c5ce4385e13e75 100644 --- a/docs/howtos/migrate-a-gcp-cloud-run-app-terraform-deployment-to-v9.md +++ b/docs/howtos/migrate-a-gcp-cloud-run-app-terraform-deployment-to-v9.md @@ -135,12 +135,22 @@ In the example code mentioned above we need to update the following options: } ``` -- `sql_instance_connection_name`: this variable in now renamed to `mount_cloudsql_instance`: +- `sql_instance_connection_name`: has been renamed to `mount_cloudsql_instance`: ```tf mount_cloudsql_instance = module.sql_instance.instance_connection_name ``` +- `disable_monitoring`: has been renamed to `enable_monitoring` and the new default behaviour is to + disable monitoring. + + ```tf + enable_monitoring = true + ``` + +For a full list of the changes to input variables refer to the [explanation +page](../explanations/gcp-cloud-run-app-module.md). + ### Adapt other changes If the project has the load balancer configured, use the `moved` blocks as shown in the @@ -200,3 +210,4 @@ as the Cloud Run apps will be recreated (as well as a subset of auxiliary terraf ## Useful links - [More examples in the module's GitLab project](https://gitlab.developers.cam.ac.uk/uis/devops/infra/terraform/gcp-cloud-run-app/-/blob/master/docs/examples.md) +- [Migrating to Google Cloud Run App Terraform module v9.0.0](../explanations/gcp-cloud-run-app-module.md)