feat: add CookieBanner, CamMuiTheme, + example
For #1 (closed)
What does this MR do?
- Adds remaining code for
CookieBanner
in this repo -- it's a component you can use to add an approved cookie banner. - It also adds a theme (
CamMuiTheme
) borrowed from DA. - Adds instructions for usage in
README.md
.
Checks
- Ran through steps in README.md. All works as expected
- Compared the cookie banner to what we see in DA (AP frontend) by looking at the prod version:
- Checked that the code for
CookieBanner
andCamMuiTheme
matches the code in AP frontend.
Edited by Benjamin Woods
Merge request reports
Activity
Filter activity
assigned to @bw509
Drafted until !2 (merged) is merged. In principle, all working -- just doing smaller MRs as a courtesy to the reviewers
added 8 commits
-
d57d106e...227db8de - 3 commits from branch
main
- f587eb38 - feat: add basic-usage example folder
- acd10a77 - feat: add CookieBanner code, plus shim
- bdc831e7 - feat: patch package.json, add new deps
- ca5aed4d - feat: bind CookieBanner to test app, install library in test app
- 088281a6 - doc: update README.md, CHANGELOG.md, version
Toggle commit list-
d57d106e...227db8de - 3 commits from branch
I ended up needing to rollback the version of
react-cookie
. I'll make an issue here and in AP frontend.Essentially,
react-cookie>=6.0.0
will break the code, as it currently stands. That's due to some javascript quirks with the handling of'0'
vs0
.Edited by Benjamin Woodsrequested review from @ek599
mentioned in commit 5c8e0a0e
Please register or sign in to reply