FAQ | This is a LIVE service | Changelog

Skip to content

fix: resolve import problem for identitylib.photo_client.models.v1_beta1_photo_identifier_summary

Benjamin Woods requested to merge issue-40-failing-to-compile into main

Fix #40 (closed)

What does this MR do?

It resolves a problem where identitylib.photo_client.models.v1_beta1_photo_identifier_summary failed to import (see issue desc).

  1. Problem covered with a failing inline integration test (the dockerfile fails to build if there is a JIT compilation problem on import)
  2. Problem fixed by upgrading openapitools/openapi-generator-cli version to 7.6.0. See here for more info in the 7.4.0 release notes
  3. Updates yaml
  4. Updates changelog

Note that the JIT compilation check will only check that the module is syntactically correct Python code, requiring first class citizen at the module level to compile correctly. It will not check if the code has bad referencing in function scope, etc etc. as that is handled at runtime. It will check for class instantiation as that stuff runs through the standard class/metaclass constructor etc etc

Checks

  1. poetry run poe build-local runs correctly
  2. poetry run poe tox runs correctly (I believe you only need to run this one, in principle)
Edited by Benjamin Woods

Merge request reports