FAQ | This is a LIVE service | Changelog

Skip to content
Snippets Groups Projects

Add ci protobuf generator

Merged Sebastiaan ten Pas requested to merge 3-ci-protobuf-generator into main
All threads resolved!

Closes #3 (closed)

Most work was done by @mk2155 in https://gitlab.developers.cam.ac.uk/uis/devops/experiments/mk2155/protobuf-prototype. I made a couple of changes to match what we have in main currently. I also skipped the code logic to automatically create __init__.py files, as this is not needed anymore now we make use of betterproto.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 6de44a1c - feat: add ci protobuf generator

    Compare with previous version

  • added 1 commit

    • 6c1457dd - feat: add ci protobuf generator

    Compare with previous version

  • Sebastiaan ten Pas
  • mentioned in issue #3 (closed)

  • Mike Knee requested review from @mk2155

    requested review from @mk2155

    • Resolved by Mike Knee

      I'm just going to drag @rjw57 into this conversation as well - you might be interested in this from a common-pipeline PoV. We've tried to make this pipeline consistent with current approaches (shamelessly ripped from the OpenAPI pipeline), and our eventual hope is to move this into the common pipeline as part of this epic (in issue #4). A quick look at this stage to check our approach here in terms of the gitlab-ci being common-pipeline friendly would be appreciated, although I'm assigned as reviewing so just a quick look to check we haven't done anything bonkers is really the ask :smile:

    • Resolved by Mike Knee

      It might be useful to have a poe command that mimics the build process from the pipeline - e.g. copies around the generator_static required code etc. and produces the package artifacts locally.

      Apart from that, I think this looks good!

  • added 1 commit

    • ada592ef - feat: add ci protobuf generator

    Compare with previous version

  • Mike Knee
  • added 1 commit

    • f3d47dde - feat: add ci protobuf generator

    Compare with previous version

  • Mike Knee approved this merge request

    approved this merge request

  • Mike Knee resolved all threads

    resolved all threads

  • mentioned in commit f79a2e39

  • Please register or sign in to reply
    Loading