Add ci protobuf generator
Closes #3 (closed)
Most work was done by @mk2155 in https://gitlab.developers.cam.ac.uk/uis/devops/experiments/mk2155/protobuf-prototype. I made a couple of changes to match what we have in main
currently. I also skipped the code logic to automatically create __init__.py
files, as this is not needed anymore now we make use of betterproto
.
Merge request reports
Activity
assigned to @st981
- Resolved by Mike Knee
- Resolved by Sebastiaan ten Pas
mentioned in issue #3 (closed)
requested review from @mk2155
- Resolved by Mike Knee
I'm just going to drag @rjw57 into this conversation as well - you might be interested in this from a
common-pipeline
PoV. We've tried to make this pipeline consistent with current approaches (shamelessly ripped from the OpenAPI pipeline), and our eventual hope is to move this into the common pipeline as part of this epic (in issue #4). A quick look at this stage to check our approach here in terms of the gitlab-ci being common-pipeline friendly would be appreciated, although I'm assigned as reviewing so just a quick look to check we haven't done anything bonkers is really the ask
- Resolved by Mike Knee
It might be useful to have a
poe
command that mimics the build process from the pipeline - e.g. copies around thegenerator_static
required code etc. and produces the package artifacts locally.Apart from that, I think this looks good!
- Resolved by Mike Knee
- Resolved by Sebastiaan ten Pas
mentioned in commit f79a2e39