FAQ | This is a LIVE service | Changelog

Skip to content
Snippets Groups Projects

feat: correct password app reset token call and handle missing users

Merged Robin Goodall requested to merge fix-reset-token-call into main
All threads resolved!

Fixes for https://gitlab.developers.cam.ac.uk/uis/devops/iam/activate-account/api/-/issues/25

Now returns a 400 - validation error

{
    "crsid": "Password App was unable to find the user"
}

Or 503 - service unavailable - on any other failure

And doesn't retry if the password app couldn't find the user (aka raven db said it didn't exist to set the token on)

Edited by Robin Goodall

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Robin Goodall resolved all threads

    resolved all threads

  • Robin Goodall added 1 commit

    added 1 commit

    • 25ba9ace - review: separate exception handling

    Compare with previous version

  • E. Evstafiev approved this merge request

    approved this merge request

  • Robin Goodall mentioned in commit 1bb43176

    mentioned in commit 1bb43176

  • merged

  • Merged and set 0.14.0 release it MR to merge when its pipeline finishes. Feel free to merge the MR from renovate bot seeing 0.14 being available on Monday else I'll do it Tuesday.

  • Please register or sign in to reply
    Loading