FAQ | This is a LIVE service | Changelog

Skip to content
Snippets Groups Projects

Add new page for GitLab Package Registry config

Merged Kevin Hooke requested to merge add-maven-settings-xml-config-page into master

Added new page for configuring Maven settings.xml to access GitLab Package Registries

Edited by Kevin Hooke

Merge request reports

Pipeline #657307 passed

Pipeline passed for 88444961 on add-maven-settings-xml-config-page

Approved by

Merged by Kevin HookeKevin Hooke 3 weeks ago (Jan 17, 2025 1:09pm UTC)

Loading

Pipeline #678018 passed

Pipeline passed for 1e4233a3 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dr Rich Wareham
  • Dr Rich Wareham
  • Dr Rich Wareham
  • Dr Rich Wareham
  • I did a (pedantic) pass for style and language. None of my comments are hills I'd die on except that we should call the GitLab package registry by its proper name. Feel free to ignore the other comments if they don't align with your own tastes.

    I've not reviewed for correctness. I feel @av603 is better placed to do that as he's worked with the relevant projects.

  • Kevin Hooke added 1 commit

    added 1 commit

    • 2b4062f5 - Registry name change for consistency

    Compare with previous version

  • Kevin Hooke added 1 commit

    added 1 commit

    • 6df13d60 - Added suggestion to replace comment in parens.

    Compare with previous version

  • Kevin Hooke added 1 commit

    added 1 commit

    Compare with previous version

  • Kevin Hooke added 1 commit

    added 1 commit

    Compare with previous version

  • Kevin Hooke added 2 commits

    added 2 commits

    • 3f4aba5e - fixed pre-commit issue
    • 88444961 - Merge branch 'add-maven-settings-xml-config-page' of...

    Compare with previous version

  • assigned to @kh816

  • Kevin Hooke requested review from @prb34 and @wgd23

    requested review from @prb34 and @wgd23

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading