FAQ | This is a LIVE service | Changelog

Skip to content

Migrating the repo to RushJS

Richard Peach requested to merge rushjs-migration into master

This merge request migrates the repo to RushJS

Notable mentions:

  • Rush deals with publishing and versioning packages itself via a changelog process so all of that had to be reworked
  • The compose.sh scripts were annoying and not particularly useful so they have been removed
  • The gitlab pipelines have been reworked so that builds of the design-system and docs site happen in separate steps
  • The prettier and lint config are now global to the entire repo
  • The prettier config changed slightly so there are lots of quote changes (apologies for the review difficultly)
  • We now use rush commands rather than npm, this uses pnpm under the hood
  • Rush will fail a build if any warnings are logged to stderr so a significant amount of work went into resolving those. This significantly improved the hygiene of our setup and future warnings should not be ignored

To the reviewer, I would suggest the following:

  • Test everything in the README
  • Check the pipeline passes
  • Check the Merge commits 4e01598c and 95bcc68a
  • Look at the publishing gitlab step, I've run a dryrun that seems to pass but not run a full publish

closes #18 (closed)

closes https://gitlab.developers.cam.ac.uk/uis/devops/digital-admissions/admissions-portal/ap-frontend/-/issues/57

Edited by Richard Peach

Merge request reports