Acrobatreaderdc.xml

NOTE. a per-institution config file is needed

added 5 commits

• 03272331 - acrobatreaderdc does not need to be in versioned sub-dir
• 5e920f3b - acrobatreaderdc: use mst if present but skip transform if not
• 84e2a7a7 - acrobatreaderdc: use variable for logdir rather than hard-coded path
• 68ec9b9e - acrobatreaderdc: remove unnecessary duplicate variable
• 90c73c78 - acrobatreaderdc: skip unnecessary acknowledgement of exit code 0

Compare with previous version

assigned to @cm214 and unassigned @alt36

assigned to @alt36 and unassigned @cm214

@cm214 I'd like you to approve my recent commits but because of how we have the ucam_wpkg repo approval rules set up, I can't do that! We might have to think about how to handle this in the future. But for now....

The main potential problem for you I've introduced is 03272331 : I've moved the path of the MST, because I've never had a need to use a differently-versioned MST, and putting the version number in the MST path will make it a pain every time we update the package (which of course happens pretty regularly with this package!) But my commit 5e920f3b then mitigates the potential problem, by either a) using the MST if it's in the expected place, or b) not using a MST if it's not.

I think this package is therefore now ready for approval & merging, but I'll wait until you've replied to this comment before doing so.

@alt36 I've looked through the commits, they make sense to me, so I'm happy for the merge to take place.

@alt36 I've looked through the commits, they make sense to me, so I'm happy for the merge to take place.

approved this merge request

merged

mentioned in commit 676e817f

mentioned in issue #2 (closed)