Registry path miss-match

In 6fad20a0 the registry path for the Remove includes an extra level not include in the install - HKLM\software\ch.cam.ac.uk\WPKG , 'WPKG' is extra. I don't see this extra 'WPKG' in anothe package that uses the registry for a check, olex2.xml for example. Should 'WPKG' be there therfore olex2.xml needs changing?

to add to my first comment. It seems that if the remove line (spri-shortcuts) should be WIHTOUT the WPKG then the reg delete line needs to be:

reg delete HKLM\software\ch.cam.ac.uk\spri-shortcuts /f

if the install line stays as it is:

reg add HKLM\software\ucam_wpkg.cam.ac.uk\spri-shortcuts /t reg_sz /v version /d %version% /f

the '/v' is not needed in the reg delete line

The old version of spri-shortcuts did reg add HKLM\software\ch.cam.ac.uk\WPKG /t reg_sz /v spri-shortcuts /d %version% (see https://gitlab.developers.cam.ac.uk/ch/co/wpkg/wpkg-packages/-/commit/0b21ff8b71851b93350da68da3a70edde931c90a) which is why there's the corresponding check for and potential removal of reg delete HKLM\software\ch.cam.ac.uk\WPKG /v spri-shortcuts in the ucam_wpkg version.

For new packages, I think I've been aiming for

reg add HKLM\software\ucam_wpkg.cam.ac.uk\spri-shortcuts /t reg_sz /v version /d %version%

rather than something like

reg add HKLM\software\ucam_wpkg.cam.ac.uk /t reg_sz /v spri-shortcuts /d %version%

because I've got some packages where I think it'll be useful to be able to record multiple registry values other than just the version. But the delete command I'm using is still then

reg delete HKLM\software\ucam_wpkg.cam.ac.uk\spri-shortcuts

to remove that spri-shortcuts key and all values contained within it.

I think that's all consistent with what I suggested at https://gitlab.developers.cam.ac.uk/ch/co/ucam_wpkg/-/wikis/Packaging-Conventions#example but let me know if I'm wrong!