FAQ | This is a LIVE service | Changelog

Skip to content
Snippets Groups Projects
Commit 7b86172a authored by Dr Adam Thorn's avatar Dr Adam Thorn
Browse files

acrobatx: make package installable by institutions other than Maths

parent 7d4d4399
No related branches found
No related tags found
Checking pipeline status
Hide whitespace changes
Inline Side-by-side
Showing
with 15 additions and 1 deletion
  • Dr Adam Thorn @alt36 ·
    Author Owner

    @cm214 I think we need to be careful to make sure that any packages in the repo are installable by all users of the repo - if there's a need to hard-code things which are specific to a single institution then we should consider carefully if the package should instead be in our individual Dept repos. In practice I think that means that any package that specifically references "maths-config" or "chemistry-config" needs a little thought.

    In this instance I've followed the same pattern as we've used in acrobatreaderdc.xml : define the path to an MST which is relative to %WPKGINSTITUTION%, then have conditions on the install command which use the MST if present but just install the vanilla MSI if not.

    This installs fine for me in Chemistry, and I believe my change is effectively a no-op when %WPKGINSTITUTION% is maths.

  • Mr Chris B Mortimer @cm214 ·
    Maintainer

    Good edit, I slipped up there.

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment