FAQ | This is a LIVE service | Changelog

Commit d75a61af authored by Dr Abraham Martin's avatar Dr Abraham Martin
Browse files

Merge branch 'issue-32-idempotency' into 'master'

add additional attrbutes to ignore changes list

See merge request !17
parents 44eab491 df8228ba
Pipeline #72635 passed with stage
in 1 minute
# Changelog
All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## [2.0.1] - 2021-03-09
### Changed
- Add some more attributes to those ignored to reduce terraform noise in plans.
## [2.0.0] - 2021-01-27
### Added
- Initial version
......@@ -29,6 +29,9 @@ resource "google_cloud_run_service" "webapp" {
metadata {
annotations = merge(
{
"serving.knative.dev/creator" : "placeholder",
"serving.knative.dev/lastModifier" : "placeholder",
# As mentioned at https://www.terraform.io/docs/configuration/resources.html#ignore_changes
# placeholders need to be created as the adding the key to the map is
# considered a change and not ignored by ignore_changes. This needs to
......@@ -71,6 +74,7 @@ resource "google_cloud_run_service" "webapp" {
"client.knative.dev/user-image" = "placeholder"
"run.googleapis.com/client-name" = "placeholder"
"run.googleapis.com/client-version" = "placeholder"
"run.googleapis.com/sandbox" = "placeholder"
},
# Annotations which are only set if there is a Cloud SQL instance:
......@@ -144,6 +148,14 @@ resource "google_cloud_run_service" "webapp" {
template[0].metadata[0].annotations["client.knative.dev/user-image"],
template[0].metadata[0].annotations["run.googleapis.com/client-name"],
template[0].metadata[0].annotations["run.googleapis.com/client-version"],
template[0].metadata[0].annotations["run.googleapis.com/sandbox"],
# These are only changed when "run.googleapis.com/launch-stage" is "BETA".
# It's non-trivial to make ignore_changes dependent on input variables so
# we always ignore these annotations even if, strictly speaking, we only
# need to do so is local.enable_beta_launch_stage is true.
metadata[0].annotations["serving.knative.dev/creator"],
metadata[0].annotations["serving.knative.dev/lastModifier"],
# If the allowed ingress variable is specified, ignore feedback about
# its status. We cannot make the presence of this ignore be dependent on
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment