From a3dbe4a7a85bfb92eeb7c557aa5e473e02227695 Mon Sep 17 00:00:00 2001
From: Abraham Martin <amc203@cam.ac.uk>
Date: Thu, 20 Dec 2018 13:20:27 +0100
Subject: [PATCH] PEP8 fixes
---
ucamlookup/__init__.py | 2 +-
ucamlookup/admin.py | 2 +-
ucamlookup/apps.py | 2 +-
ucamlookup/tests.py | 4 ++--
ucamlookup/utils.py | 2 +-
ucamlookup/views.py | 1 +
6 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/ucamlookup/__init__.py b/ucamlookup/__init__.py
index 037829c..91fac1e 100644
--- a/ucamlookup/__init__.py
+++ b/ucamlookup/__init__.py
@@ -1,4 +1,4 @@
-from ucamlookup.utils import *
+from ucamlookup.utils import * # noqa: F403,F401
default_app_config = 'ucamlookup.apps.UCamLookupConfig'
diff --git a/ucamlookup/admin.py b/ucamlookup/admin.py
index 4437e58..f4acb80 100644
--- a/ucamlookup/admin.py
+++ b/ucamlookup/admin.py
@@ -6,7 +6,7 @@ from django import forms
from ucamlookup.models import LookupGroup
-class UserCreationForm(forms.ModelForm):
+class UserCreationForm(forms.ModelForm): # noqa: F811
"""
A form that creates a user, with no privileges, from the given username and
password.
diff --git a/ucamlookup/apps.py b/ucamlookup/apps.py
index 79c0ac6..6553c9c 100644
--- a/ucamlookup/apps.py
+++ b/ucamlookup/apps.py
@@ -7,4 +7,4 @@ class UCamLookupConfig(AppConfig):
def ready(self):
super(UCamLookupConfig, self).ready()
- import ucamlookup.signals
+ import ucamlookup.signals # noqa: F401
diff --git a/ucamlookup/tests.py b/ucamlookup/tests.py
index 4c57cb1..5a3b8f0 100644
--- a/ucamlookup/tests.py
+++ b/ucamlookup/tests.py
@@ -110,7 +110,7 @@ class UcamLookupTests(TestCase):
User.objects.create_user(username="amc203", password="test")
self.assertTrue(self.client.login(username='amc203', password="test"))
response = self.client.get(reverse('ucamlookup_find_people'), {'query': 'amc203', 'searchId_u': '1'})
- if sys.version_info >= (3,0):
+ if sys.version_info >= (3, 0):
jsonresponse = json.loads(response.content.decode('utf-8'))
else:
jsonresponse = json.loads(response.content)
@@ -126,7 +126,7 @@ class UcamLookupTests(TestCase):
self.assertTrue(self.client.login(username='amc203', password="test"))
response = self.client.get(reverse('ucamlookup_find_groups'), {'query': 'Information Systems',
'searchId_g': '1'})
- if sys.version_info >= (3,0):
+ if sys.version_info >= (3, 0):
jsonresponse = json.loads(response.content.decode('utf-8'))
else:
jsonresponse = json.loads(response.content)
diff --git a/ucamlookup/utils.py b/ucamlookup/utils.py
index 80eae3d..c0a6552 100644
--- a/ucamlookup/utils.py
+++ b/ucamlookup/utils.py
@@ -1,6 +1,6 @@
import re
from django.core.exceptions import ValidationError
-from ucamlookup.ibisclient import *
+from ucamlookup.ibisclient import createConnection, PersonMethods, GroupMethods, IbisException, InstitutionMethods
conn = createConnection()
diff --git a/ucamlookup/views.py b/ucamlookup/views.py
index 761826c..70f2085 100644
--- a/ucamlookup/views.py
+++ b/ucamlookup/views.py
@@ -10,6 +10,7 @@ def find_people(request):
return HttpResponse(json.dumps({'searchId_u': request.GET.get('searchId_u'), 'persons': persons}),
content_type='application/json')
+
@login_required
def find_groups(request):
groups = get_groups_from_query(request.GET.get('query'))
--
GitLab