Commit author not being associated with GitLab user

It appears that a thing called "Github integration" is not yet enabled.

Following on from #69 (closed) I am attempting to mirror repos from our existing Github organisations. However, this currently requires a token to be created, but https://docs.gitlab.com/ee/user/project/import/github.html#import-your-github-repository-into-gitlab states that this is not the preferred method:

"If you are using GitLab.com or a self-hosted GitLab instance with the GitHub integration enabled, that should be the preferred method to import your repositories."

I have tested an import (/geog/committee-listings), but it comes through showing my Github account's e-mail address in the mailto, which I am not at all happy about (being a spam generator). Presumably the full integration allows mapping of my external user to my internal user somehow.

Could you see if "GitHub integration" could be switched on?

changed the description

GitLab integration only provides a sign-in with GitHub feature and the ability to automatically generate and fetch personal access tokens when importing repositories. Enabling this is on our roadmap but it does not change what a GitHub project repository import looks like.

Edit: Martin pointed out that this statement applies only to repositories.

We have imported a number of repositories from GitHub. Currently we do this as a single user which, I'm afraid, does result in all imported merge requests and issues all being authored by the same user. See uis/devops/django/ucamlookup#5 (closed) for an example.

For repositories, however, commit authorship is preserved exactly as it is in the GitHub repo. For example, in this commit: geog/committee-listings@80929b6d the email address shown for the author matches the one in the GitHub repo:

rjw57@rjw57-uis-laptop:committee-listings (master)
$ git remote -v
origin  https://github.com/camunigeog/committee-listings/ (fetch)
origin  https://github.com/camunigeog/committee-listings/ (push)
rjw57@rjw57-uis-laptop:committee-listings (master)
$ git show 80929b6deb36f6fffecc909803bdfcba6a905f23
commit 80929b6deb36f6fffecc909803bdfcba6a905f23
Author: mvl22 <martin@lucas-smith.co.uk>
Date:   Tue Nov 14 17:25:15 2017 +0000

    Add screenshot

diff --git a/screenshot.png b/screenshot.png
new file mode 100755
index 0000000..8bc6018
Binary files /dev/null and b/screenshot.png differ

As such, the mailto link shown in the GitLab UI matches the one in your own repo and GitLab would be lying if it showed any other information.

Hope that helps.

closed

added 20m of time spent at 2019-05-30

I've opened a tracking issue at #71 (closed) to track interest in sign in with GitHub since we hadn't got a public issue for it. Thumbs-upping that is useful for us to show what features we should prioritise.

Thanks for giving us feedback.

That doesn't seem to be what the documentation states though:

https://docs.gitlab.com/ee/user/project/import/github.html#how-it-works

seems to indicate that the activity on Github will be properly associated with my username on Gitlab (mvl22), though perhaps only for issues. At the moment the listings are all creating a presumably dumb label "mvl22" with an associated mailto link (that will be a delight for spammers to pick up), and I really don't want University members starting to use that e-mail account to contact me for University business. Naturally the commits will still contain exactly the same information. The problem here is the interface not actually associating "mvl22" in Github terms with mvl22 in Gitlab.

"if you are an administrator of a self-hosted GitLab instance, you will need to enable the GitHub integration in order for users to follow the preferred import method described on this page. If this is not enabled, users can alternatively import their GitHub repositories using a personal access token from GitHub, but this method will not be able to associate all user activity (such as issues and pull requests) with matching GitLab users"

I had to use the "Using a GitHub token" method on the above documentation, but it clearly states that this is not the "preferred import method".

reopened

Forgive my possible misunderstanding, but the project you linked to as a problem project doesn't have any pull requests or issues imported and so the very docs you link to indicate it doesn't apply to your situation. (It starts with the phrase "[w]hen issues and pull requests are being imported...".)

Naturally the commits will still contain exactly the same information. The problem here is the interface not actually associating "mvl22" in Github terms with mvl22 in Gitlab.

This further leads me to think your problem is not actually with GitHub integration. As such I've taken the liberty or renaming the issue.

Unless GitLab is told about your other email addresses, it has no way to match the commit author email address to your user account. Have you configured GitLab with your other email address as a secondary address?

changed title from Enable Github integration to Commit author not being associated with GitLab user

added 15m of time spent at 2019-05-31

Unless GitLab is told about your other email addresses, it has no way to match the commit author email address to your user account. Have you configured GitLab with your other email address as a secondary address?

Ah, that is now much more satisfactory - commits link to my account page, rather than exposing in the UI my e-mail as a mailto. (Obviously they will still be in the commit data itself.)

Thanks for the pointer, which has resolved this.

Martin

Super. Glad we could help and thanks for the feedback!

closed