From fbeb7df4632d106720f0c900b3bd04b477eaafc4 Mon Sep 17 00:00:00 2001
From: lb584 <lb584@cam.ac.uk>
Date: Tue, 26 Sep 2023 13:36:36 +0100
Subject: [PATCH] fixing faulty logic for checking job success
---
coordinator/ProcessorServer.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/coordinator/ProcessorServer.py b/coordinator/ProcessorServer.py
index 3593fdd..c3f3bf8 100644
--- a/coordinator/ProcessorServer.py
+++ b/coordinator/ProcessorServer.py
@@ -61,7 +61,7 @@ def process_pre_job_server_download(input_args: dict):
status = subprocess_and_log(cmd_check_file, description_short, description_long, check = False,
shell = run_in_shell)
- data_is_ready = status.returncode > 0
+ data_is_ready = status.returncode == 0
if not data_is_ready:
@@ -97,7 +97,7 @@ def process_pre_job_server_download(input_args: dict):
logger.info(message)
endScript(premature=True)
- elif not data_is_ready:
+ elif data_is_ready:
logger.info(f"Data is available for config {i+1} of {len(config_paths)}, calculation shall proceed")
return True
--
GitLab